Refactor: Split openlibrary/core/vendors to make it easier to manage #6684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
added
Theme: Development
Closed
cclauss
changed the title
cclauss
added
the
State: Blocked
cclauss
force-pushed
the
split-openlibrary_core_vendors
branch
from
f3e84ed to
4451ad0
Compare
cclauss
changed the title
|
@cclauss if you'd like to rebase, we can throw on testing (although we really won't know until we deploy on ol-home0 affiliate server -- which we don't have sentry for) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't easy to understand and modify our affiliates/vendors code because it mixes both Amazon and Better World Books logic in a single file which is used to drive the affiliate server and several different web activities.
Separating the logic into vendor-specific files should make it easier to understand and maintain.
Technical
Testing
Screenshot
Stakeholders