Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to lists documentation from empty lists page #6686

Merged

Conversation

Jyotiraditya24
Copy link
Contributor

Closes #6633

My Lists page is linking to instructions to create a list

Technical

Testing

Screenshot

Stakeholders

@mekarpeles mekarpeles self-assigned this Jun 25, 2022
@mekarpeles
Copy link
Member

I believe we only want the messaging to the patron who manages the list. Since lists are public, all patrons will see the page, but only the maintainer/owner should see a link to the docs.

@mekarpeles mekarpeles added Theme: Testing Involves work related to testing infrastructure, development, and ops. [managed] and removed Theme: Testing Involves work related to testing infrastructure, development, and ops. [managed] labels Jun 25, 2022
@mekarpeles mekarpeles merged commit 5e8c4b1 into internetarchive:master Jun 25, 2022
@Jyotiraditya24
Copy link
Contributor Author

@mekarpeles thankyou for all your help , this was my first open source contribution

@cdrini cdrini changed the title Update lists.html Add link to lists documentation from empty lists page Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The My Lists page should link to instructions to create a list
2 participants