-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index sortable work title field in solr #6697
Index sortable work title field in solr #6697
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This looks great, @mheiman !
I think the only blocker to merging is making sure we wrap things with if get_solr_next()
so that we won't show title sorting option until a full re-index is performed. This is a little annoying, since a lot of the variables aren't available at the right time! It might be easier to add a new variable, title_sort_solr
to the openlibrary.yml features section, and then check for that instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Not testing; saw Mark's demo and it looked good! He also confirmed it was working with copyField
0a46b38
to
7959716
Compare
Closes #201
Adds title sorting functionality to author and search pages.
Technical
The manage_schema type definition includes handling for initial articles from a variety of common languages (English, Spanish, French, German, Italian) but could be expanded to include additional languages.
Source: https://www.loc.gov/marc/bibliographic/bdapndxf.html
Testing
This will require a SOLR reindex to work. After that, the Alphabetical sort option should function correctly on author and search pages.
Stakeholders
@mheiman @cdrini