Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch RelatedWorksCarousel to use solr #7137

Merged

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Nov 9, 2022

Fix. Performance and unnecessary hits to IA metadata. Closes #7136 .

Removes 10s of archive.org metadata API calls per OL book page load!

Technical

Testing

  • Books without subjects work
  • Books in results are comparable (see screenshots)

The timing improvements on testing are quite promising!

image

The line ~15:00 is when this PR was deployed to testing.

Screenshot

Results look better or comparable:

image

image

Stakeholders

@cdrini cdrini force-pushed the fix/related-carousels-use-solr branch from 050358f to 03d0ab8 Compare November 9, 2022 19:27
@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Nov 9, 2022
@cdrini cdrini marked this pull request as ready for review November 9, 2022 19:57
@cdrini cdrini added Theme: Performance Issues related to UI or Server performance. [managed] Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. labels Nov 9, 2022
@mekarpeles mekarpeles self-assigned this Nov 14, 2022
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Nov 14, 2022
@mekarpeles mekarpeles merged commit b3b532a into internetarchive:master Nov 16, 2022
@cdrini cdrini deleted the fix/related-carousels-use-solr branch November 16, 2022 19:51
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Theme: Performance Issues related to UI or Server performance. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary IA metadata calls on /partials page
3 participants