Solves #6660 whole issue of duplicating pagination for user lists #7149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Awesome, thank you @mariamalth ! This looks perfect :) I tested it on testing.openlibrary.org
cdrini
added
the
On testing.openlibrary.org
|
Darn I forgot to squash the commits! Oh well, next time! |
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6660
This PR achieves a feature where clicking on lists now has pagination at the top and bottom of the lists.
Technical
In the “view_body.html” in templates/type/list, the div with class “mybooks-list” now has a macros pager and an additional div with class “clearfix”. This is done so the presentation of the pagination elements remains consistent at the top and bottom of the lists page.
Testing
To reproduce or verify what this PR fixes, one should create or access a list of over 50 items (so there are enough items to present pagination). After completing the above one should look at the people/username/lists/list_id/list_name page and find that pagination is present on the top and the bottom.
Screenshot
Stakeholders
@seabelis @cdrini @mekarpeles