Add client_id, s3, scope to bulk availability API #7522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
cclauss
reviewed
Feb 11, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
for more information, see https://pre-commit.ci
mekarpeles
added
the
Patch Deployed
cdrini
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Code lgtm; not testing. @mekarpeles and @ximm have tested. Expediting to unblock testing #8732
Achorn
pushed a commit
to Achorn/openlibrary
that referenced
this pull request
Jan 23, 2024
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to (internal) Bulk Availability API PR https://git.archive.org/ia/petabox/-/merge_requests/3516/diffs
This PR decorates our calls to the Bulk Availability API (petabox) to include headers with s3 authorization, scope, application, and client_ip to help enforce security/permissions and rate limiting.
Technical
The
scopefield may need to be changed? I'm not sure what values are acceptable.Testing
This PR can be deployed to testing when there's a petabox PR to test against
Stakeholders
@ximm @cdrini