-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test/realtime account validation #7974
Unit test/realtime account validation #7974
Conversation
|
|
Fixed |
Blocked by changes to the registration page: #7670. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, @vnsrz. This looks good to me. I'm removing the Jest setup steps that you have added, as similar code was added by #7962.
Some of the tests could be simplified with a second beforeEach
call that sets the variables that are same and used by each test. I'll make some small changes to DRY the tests in another PR. Will mention you as a stakeholder so that you'll see what I mean.
Thanks for these new tests, @vnsrz! Apologies for taking so long to review them. |
Adds unit tests for the file
realtime_account_validation.js
, particularly on the password validation.This was made for educational purposes.
Technical
To test the JQuery in the
initRealtimeValidation
method, asetup-jest.js
file importing the$
identier had to be created and added to thepackage.json
. As far as I know, this doesn't affect the other tests being ran, as they still passed.Testing
Run
docker compose exec web make test
, there should be 17 tests running and passing now, as opposed to 16 before.Screenshot
Stakeholders