Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error when displaying git SHA in footer #8214

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Handle error when displaying git SHA in footer #8214

merged 2 commits into from
Aug 21, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 21, 2023

#8187 (review) If git rev-parse --short HEAD -- fails then return "unknown" as the version number.

Closes #8211

Technical

Testing

Screenshot

Stakeholders

@badlektor

@cclauss
git rev-parse --short HEAD
266af17 
Fixes #8187 (review)
If `git rev-parse --short HEAD --` fails then return "unknown" as the version number.
@cclauss cclauss requested a review from jimchamp August 21, 2023 22:11
@jimchamp
Copy link
Collaborator

This is working:
image

Thanks Chris!

@jimchamp jimchamp merged commit 0dc6925 into master Aug 21, 2023
@cclauss cclauss deleted the git-rev-parse---short-HEAD branch August 21, 2023 22:18
@cdrini cdrini changed the title git rev-parse --short HEAD Handle error when displaying git SHA in footer Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimchamp jimchamp Awaiting requested review from jimchamp

Assignees

@jimchamp jimchamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOCKER: git rev-parse --short HEAD --` returns a non-zero exit status 128. web container won't load
2 participants
@cclauss @jimchamp