Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY account validation unit tests #8227

Conversation

jimchamp
Copy link
Collaborator

DRYs recently added realtime account validation unit tests by adding a nested beforeEach call. Renamed some variables.

Technical

Testing

Screenshot

Stakeholders

@vnsrz

@codecov-commenter
Copy link

Codecov Report

Merging #8227 (a99a12a) into master (dcd69f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8227   +/-   ##
=======================================
  Coverage   16.97%   16.97%           
=======================================
  Files          72       72           
  Lines        3789     3789           
  Branches      654      654           
=======================================
  Hits          643      643           
  Misses       2728     2728           
  Partials      418      418           

@scottbarnes scottbarnes merged commit 0eda27d into internetarchive:master Sep 18, 2023
@jimchamp jimchamp deleted the refactor/DRY-rt-account-validations branch September 25, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants