add share_target for progressive web app #8238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8197
This will make it so if someone highlights text on their phone and hit's share they have the option to share it to OL (if they have the PWA installed).
Technical
Just following the guide here: https://developer.chrome.com/en/articles/web-share-target/
"text": "q"is so that the text shared has aqquery param which is what our search page uses.Browser Compatibility
This doesn't work if you "Install" the PWA from FF or Safari but you can happily share from them if you use install the pas via other browsers.
https://developer.mozilla.org/en-US/docs/Web/Manifest/share_target#browser_compatibility
Testing
PWAs need to be installed on https so can we please put this on the OL test env?
However, I created my own PWA to play around with the APIs so I'm confident this will work.
Screenshot
Video of it working on testing!
pwa_share_optimized.mp4
Stakeholders
@Yashs911 and maybe @jimchamp ?