Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate id from top notice #8249

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

jimchamp
Copy link
Collaborator

Removes id footer-locale-menu from the site's top notice bar. This id is also used in the footer, and is not referenced elsewhere in the codebase.

Technical

Testing

Screenshot

Stakeholders

Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove both of the ids if they're unused, @jimchamp ? Otherwise lgtm, merge at your discretion!

@cdrini cdrini self-assigned this Aug 31, 2023
@jimchamp
Copy link
Collaborator Author

Done. Please do the same when you see ids that are not referenced.

@cdrini cdrini merged commit c7c1d52 into internetarchive:master Aug 31, 2023
@jimchamp jimchamp deleted the remove-duplicate-id branch September 25, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants