add ARM64/M1 support for building olbase image #8254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this one through without testing it ; this does add some complexity to our olbase, but I can see the value for Mac users who might want to build olbase. We'll try it in the next deploy, and if it fails we will roll this change back. Actually maybe @scottbarnes would you mind testing olbase build on linux with these changes? Then merge if the build succeeds. Ty! |
|
This built for me with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6316
I want to be able to build on my m1 mac and this fix enables that.
Technical
Solution based on discussion in the issue above.
TARGETARCHwasn't working so I went withuname -mwhich seems to be a common solution.Testing
It works on my m1 mac. I also tested it on gitpod and had no problems.
But ultimately openresty isn't used for dev so someone will need to check it on testing to be sure.
Run
docker build -t openlibrary/olbase:my-test-label -f docker/Dockerfile.olbase .Stakeholders
@cdrini @cclauss