Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove leftover references to borrow.html #8259

Merged

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Sep 1, 2023

Removing some old code

borrow.html was removed in #5644

Testing

No testing needed files were not referenced anywhere.

Stakeholders

@jimchamp who refactored some of this a while ago

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #8259 (b3dfeb1) into master (f7388d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8259   +/-   ##
=======================================
  Coverage   16.97%   16.97%           
=======================================
  Files          72       72           
  Lines        3789     3789           
  Branches      654      654           
=======================================
  Hits          643      643           
  Misses       2728     2728           
  Partials      418      418           

@mekarpeles mekarpeles self-assigned this Sep 5, 2023
@mekarpeles mekarpeles assigned jimchamp and unassigned mekarpeles Sep 18, 2023
@mekarpeles
Copy link
Member

@jimchamp if we can check that homepage etc looks ok when PR deployed to testing, I think we can merge, provisionally LGTM

@mekarpeles mekarpeles added the Priority: 3 Issues that we can consider at our leisure. [managed] label Sep 18, 2023
@jimchamp jimchamp added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Sep 21, 2023
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RayBB!
I don't see any references to elements with ID borrowbook in the codebase. Homepage styling also appears as expected.

@jimchamp jimchamp merged commit fec72fc into internetarchive:master Sep 21, 2023
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 3 Issues that we can consider at our leisure. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants