Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to specify end_id for archival run #8276

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

mekarpeles
Copy link
Member

This allows us to run archival (starting at whatever the current/next record is) to any desired end_id, which allows us to process more records at a time. This is different than limit which has no way to guarantee our ending point is the logical end of a batch, (e.g. a number like 8,110,000)

Technical

Testing

Screenshot

Stakeholders

@mekarpeles mekarpeles added this to the Sprint 2023-09 milestone Sep 9, 2023
@cdrini cdrini added Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed] Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. labels Sep 11, 2023
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm ; not testing this one since the test flow is a little complicated, and I reckon you've tested it! And the code change looks pretty simple.

@cdrini cdrini merged commit 78bee5d into master Sep 18, 2023
@cdrini cdrini deleted the feature/cover-archival-end-ids branch September 18, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants