-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generalized de-dupe for ISBN and LCCN for edit edition form #8280
Conversation
1305838
to
2bdfb55
Compare
Codecov Report
@@ Coverage Diff @@
## master #8280 +/- ##
==========================================
+ Coverage 17.08% 17.10% +0.02%
==========================================
Files 75 75
Lines 3946 3947 +1
Branches 675 675
==========================================
+ Hits 674 675 +1
Misses 2842 2842
Partials 430 430
|
62cc49c
to
72539d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! One suggestion to consider.
4d5192b
to
b814ad3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for this!
Closes #8281
Implements the new de-dupe function for the edit edition page that accepts any identifier type.
Technical
Testing
Screenshot
LCCN
ISBN 10
Stakeholders
@scottbarnes