-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make covers.py compatible with web.py cgi.FieldStorage removal #8313
Make covers.py compatible with web.py cgi.FieldStorage removal #8313
Conversation
Note: This will need to update |
I am investigating a problem with this PR and webpy v0.70. |
It looks like there's a discrepancy between The |
@scottbarnes Is this still needed or is the new webpy update a drop-in replacement now? |
Alas, it is still needed. |
feb4645
to
d91ab83
Compare
@mekarpeles, I'm sorry for being a bit slow, but what sort of input are you looking for? |
Closes #8147
NOTE: This is blocked pending an update toweb.py
. We have a few proposed solutions for that. Here's one: webpy/webpy#773.Fix.
This changes
covers.py
to reflect the changed field names brought on byweb.py
's switch tomultipart
.Deploy Notes
This will affect every request made on the website + cover uploads. We'll want to monitor after deploying (and also try on staging)
Technical
Some field names changed, as the diff will show.
Additionally, the
web.py
version inrequirements.txt
has been pinned to the commit with thecgi.FieldStorage
change: webpy/webpy@ed3e92c.Testing
web.py
, and although all the tests pass here, it's possible there's some changed functionality somewhere.Stakeholders
@mekarpeles
@tfmorris