-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to node 20 #8322
upgrade to node 20 #8322
Conversation
b9139a3
to
00d6b6e
Compare
|
Codecov Report
@@ Coverage Diff @@
## master #8322 +/- ##
=======================================
Coverage 16.66% 16.66%
=======================================
Files 83 83
Lines 4422 4422
Branches 757 757
=======================================
Hits 737 737
Misses 3202 3202
Partials 483 483 |
Awesome thank you @RayBB ! I'll need to find a way to build this image so you can test on it. Are you still having issues on mac? :/ Also just to confirm, is 20 the LTS version? |
@cdrini I was able to build it on GitPod (I didn't bother trying locally b/c I'm low on battery). Logging in works, editing author identifiers, the library explorer loads (but is empty as usual), and as far as I can tell everything seems fine. Is it possible to put this on testing for a few days and see if any issues pop up? Or are there any other parts we should explicitly test. Because we use node/webpack just for building (and don't have a nodejs server) I feel issues should generally be caught at the build step if there were major ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok was able to successfully build/put on testing! LGTM ty @RayBB !
This might cause some headaches with package-lock.json files being out-of-sync/incorrect for folks. Will do another deploy tomorrow so this goes out and everyone can pull the latest version down and run a npm i --no-audit
get everything.
Closes #8257
This upgrades us to node 20!
Technical
We have to update bundlesize because it has a dependency that won't work with node 20. See this.
Testing
We have to rebuild the docker image and I'm having some trouble with that on my machine.
Maybe we can put it on testing?
Screenshot
Stakeholders
@cdrini