import api: use edition ID from IA metadata if it exists #8331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8290 #8289
Fix
Technical
Currently
ia_import()
in the import API does not use Open Library edition IDs from Internet Archive metadata because it is using the wrong field --metadata['openlibrary']
instead ofmetadata[openlibrary_edition]
.This PR fixes that, and ensures we won't make a new edition when trying to import an IA record. Additionally, it avoids at least two further database calls that would have been made in an attempt to find a match.
Testing
Try to import an IA record and see that 'step 2' now works as intended and gets the existing Open Library edition ID from the Internet Archive metadata, rather than relying on finding a match by searching the Open Library database.
@cdrini