ruff rule UP007: Use X | Y for type annotations

[cclauss]

Closes #8327

https://docs.astral.sh/ruff/rules/non-pep604-annotation

% ruff --select=UP007 --fix .

Found 99 errors (97 fixed, 2 remaining).

% ruff rule UP007

non-pep604-annotation (UP007)

Derived from the pyupgrade linter.

Autofix is sometimes available.

What it does

Check for type annotations that can be rewritten based on PEP 604 syntax.

Why is this bad?

PEP 604 introduced a new syntax for union type annotations based on the
| operator. This syntax is more concise and readable than the previous
typing.Union and typing.Optional syntaxes.

This rule is enabled when targeting Python 3.10 or later (see:
[target-version]). By default, it's also enabled for earlier Python
versions if from __future__ import annotations is present, as
__future__ annotations are not evaluated at runtime. If your code relies
on runtime type annotations (either directly or via a library like
Pydantic), you can disable this behavior for Python versions prior to 3.10
by setting [pyupgrade.keep-runtime-typing] to true.

Example

from typing import Union

foo: Union[int, str] = 1

Use instead:

foo: int | str = 1

Options

• target-version
• pyupgrade.keep-runtime-typing

Technical

Testing

Screenshot

Stakeholders

[RayBB]

Spun up the PR in gitpod and the search and such worked as expected. Also all the changes look correct to me. Just one question about openlibrary/solr/solr_types.py.

[RayBB]

What stops us from migrating openlibrary/solr/solr_types.py as well?

[cdrini]

Nothing ! That file is auto-generated though, so we'd need to change the file that generates it ( types_generator.py )

[cclauss]

And the two # noqa: UP007 in scripts/solr_builder/tests/test_fn_to_cli.py

[cdrini]

Lgtm! I believe cython/solr pipelines support this syntax , but if they don't it'll only cause an issue during full reindex, and I can easily address that.