Fix promise future dates

openlibrary/catalog/add_book/__init__.py

@@ -785,6 +785,10 @@ def normalize_import_record(rec: dict) -> None:
     if not isinstance(rec['source_records'], list):
         rec['source_records'] = [rec['source_records']]
 
+    publication_year = get_publication_year(rec.get('publish_date'))
+    if publication_year and published_in_future_year(publication_year):
+        del rec['publish_date']
+
     # Split subtitle if required and not already present
     if ':' in rec.get('title', '') and not rec.get('subtitle'):
         title, subtitle = split_subtitle(rec.get('title'))

openlibrary/catalog/add_book/tests/test_add_book.py

@@ -2,6 +2,7 @@
 import pytest
 
 from copy import deepcopy
+from datetime import datetime
 from infogami.infobase.client import Nothing
 
 from infogami.infobase.core import Text
@@ -18,6 +19,7 @@
     isbns_from_record,
     load,
     load_data,
+    normalize_import_record,
     should_overwrite_promise_item,
     split_subtitle,
     RequiredField,
@@ -1451,3 +1453,25 @@ def test_passing_edition_to_load_data_overwrites_edition_with_rec_data(
             'ia:newlyscannedpromiseitem',
         ]
         assert edition.works[0]['key'] == '/works/OL1W'
+
+
+class TestNormalizeImportRecord:
+    @pytest.mark.parametrize(
+        'year, expected',
+        [
+            ("2000-11-11", True),
+            (str(datetime.now().year), True),
+            (str(datetime.now().year + 1), False),
+            ("9999-01-01", False),
+        ],
+    )
+    def test_future_publication_dates_are_deleted(self, year, expected):
+        """It should be impossible to import books publish_date in a future year."""
+        rec = {
+            'title': 'test book',
+            'source_records': ['ia:blob'],
+            'publish_date': year,
+        }
+        normalize_import_record(rec=rec)
+        result = 'publish_date' in rec
+        assert result == expected