Improve lending error handling #8371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
commented
Oct 5, 2023
mekarpeles
added
the
Priority: 1
mekarpeles
commented
Oct 18, 2023
mekarpeles
commented
Oct 18, 2023
for more information, see https://pre-commit.ci
mekarpeles
changed the title
mekarpeles
added
the
On testing.openlibrary.org
|
@bfalling and I were discussing what to do if lending fails for a title. We may want to redirect to the Open Library book page and show a toast message |
mekarpeles
added
the
Needs: Community Discussion
jimchamp
approved these changes
Nov 3, 2023
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8372. Loosely related to #3429, we think we're seeing an uptick of lending error exception cases perhaps related to system limit. We want to add more specific reporting (e.g. response
429instead of generic400or401) so we know internally where these error cases are coming from and how to deal with them gracefully for patrons.EDIT: I think we may have converged on
409HTTP Response: Conflict or429.This PR likely depends on changes being made internally within petabox, perhaps near:
https://git.archive.org/ia/petabox/-/blob/master/www/common/Lending.inc#L111-114
Which also pertains to https://git.archive.org/ia/petabox/-/blob/master/www/common/Lending/BookLoanService.inc#L525-534 and https://git.archive.org/ia/petabox/-/blob/master/www/common/Lending/BookLoanService.inc#L570-586
Technical Notes
With this PR, when a 400 or 409 is encountered, we won't perform the borrow and will redirect the patron to archive.org (which isn't great -- they'll re-attempt to borrow and then see a indescript archive.org error -- but this is better than Open Library's stacktrace / generic see:
123871281.htmlpage)Stakeholders
@seabelis @judec @bfalling