-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed old i18n code #8373
Removed old i18n code #8373
Conversation
One thing we could potentially do is also remove references to this type from the db dump. However, I'm not sure if the dump should be edited manually. Git diff of what we could remove.
@jimchamp do you think it's okay to manually modify the dump? Or worth the effort? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the dump question, the changes look as expected.
I double checked the codebase and don't see any references to i18n that could be referring to this.
Unfortunately, I'm not sure how to test that i18n still works.
@cdrini do you have suggestions for how to check this?
@piyush-poddar replying to your comment from here. I don't have the power to merge. We need @mekarpeles or @cdrini to check it out. |
No problem mate, was just curious about my PR. |
This does look unused! Thanks @piyush-poddar and @RayBB ! |
@cdrini Happy to contribute :) |
@piyush-poddar if you'd like to contribute further you're welcome to fill out the Volunteer form (https://openlibrary.org/volunteer) and join our slack or community call! There's lot of things to do :) |
@RayBB Thanks a lot!! I would surely do that. |
You can message me on our Slack (which you should get an invite to after filling out the form!) |
@RayBB Okay thanks!! |
@RayBB @mekarpeles I filled the volunteer form yesterday, however I still haven't received the slack invite. |
@mekarpeles can you check the form when you get a chance? |
Closes #8336
Refactor: Removed the old i18n code
Technical
Testing
Screenshot
Stakeholders