Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved "add a book" to the "help" section of footer #8394

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Moved "add a book" to the "help" section of footer #8394

merged 2 commits into from
Oct 24, 2023

Conversation

piyush-poddar
Copy link
Contributor

Closes #8213

Feature: Moved "add a book" to the "help" section rather than "develop" of footer

Technical

Testing

Screenshot

Stakeholders

@RayBB
@scottbarnes

@piyush-poddar piyush-poddar mentioned this pull request Oct 6, 2023
Closed
@RayBB
Copy link
Collaborator

RayBB commented Oct 9, 2023

@piyush-poddar please post a screenshot.
Also please keep PR discussions in the PR and not on the issue. Thanks!

If possible, I suggest you join the community call that happens on Tuesdays to share what you're working on and get feedback. You can find more info in the docs.

@scottbarnes
Copy link
Collaborator

Before

Desktop

image

Tablet

image

Mobile

image

After

Desktop

image

Tablet

image

Mobile

image

scottbarnes
scottbarnes requested changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@scottbarnes scottbarnes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @piyush-poddar. Thanks for this. One small fix and I suppose this goes back to community discussion so we can show people what this looks like.

Or maybe the Needs: Community Discussion label (on issue #8213) should be removed. I guess we will find out on Tuesday during our community call from 9AM to 10AM Pacific, which you and any contributor or interested person is invited to join.

openlibrary/templates/lib/nav_foot.html Outdated Show resolved Hide resolved
@piyush-poddar @scottbarnes
Made suggested changes
d136d69 
Co-authored-by: Scott Barnes <scottreidbarnes@gmail.com>
@scottbarnes scottbarnes added Needs: Community Discussion This issue is to be brought up in the next community call. [managed] and removed Needs: Community Discussion This issue is to be brought up in the next community call. [managed] labels Oct 20, 2023
scottbarnes
scottbarnes approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feedback from the community call is that we should go ahead and merge this. Thanks, @piyush-poddar!

@scottbarnes scottbarnes merged commit 1628e56 into internetarchive:master Oct 24, 2023
2 checks passed
@piyush-poddar
Copy link
Contributor Author

@scottbarnes I'm happy to contribute :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottbarnes scottbarnes scottbarnes approved these changes

Assignees

@scottbarnes scottbarnes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move "add a book" to the "help" section rather than "develop" of footer
3 participants
@piyush-poddar @RayBB @scottbarnes