Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set content type for list seeds json api #8411

Merged

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Oct 12, 2023

Noticed we weren't setting the content-type for the seeds api in lists.

Relevant urls
http://localhost:8080/people/openlibrary/lists/OL1L.json - currently sets correct content-type
http://localhost:8080/people/openlibrary/lists/OL1L/seeds.json - doesn't currently set correct content type

Prod urls:
https://openlibrary.org/people/raybb/lists/OL235745L.json - sets content type
https://openlibrary.org/people/raybb/lists/OL235745L/seeds.json - doesn't

This PR fixes that.

Technical

Testing

See lomo

Screenshot

https://www.loom.com/share/a02c06360ce5422595daf078e5c1f99f

Stakeholders

@cclauss maybe since you're more on the backend side.

@RayBB RayBB added the Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] label Oct 12, 2023
@mekarpeles mekarpeles merged commit a8c46bc into internetarchive:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed]
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants