Fix "Want to read" button clipped on mobile #8414
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been bothering me for a while that the want to read button looks funny in the corners of the button.
It looks like this:
After my PR it looks like this:
PS: I set the width of the dropdown button to match the width of the listen button. But I'm not attached to that change.
screenshot of listen button.
Technical
Had to move the border radius code one level down to be able to hide overflow.
Did a few more small css cleanups while I was in there.
I explain more in the demo video below.
Testing
To see this change locally on search results you might need to enable
my_books_dropper
inopenlibrary.yml
Screenshot
Demo and code walkthrough: https://www.loom.com/share/b571d2aefbf4443890f9a9a345f14646
Stakeholders
Related to #8181 so I'll tag @jimchamp