Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Want to read" button clipped on mobile #8414

Merged

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Oct 13, 2023

It has been bothering me for a while that the want to read button looks funny in the corners of the button.

It looks like this:
image

After my PR it looks like this:
image

PS: I set the width of the dropdown button to match the width of the listen button. But I'm not attached to that change.

screenshot of listen button. image

Technical

Had to move the border radius code one level down to be able to hide overflow.

Did a few more small css cleanups while I was in there.

I explain more in the demo video below.

Testing

To see this change locally on search results you might need to enable my_books_dropper in openlibrary.yml

Screenshot

Demo and code walkthrough: https://www.loom.com/share/b571d2aefbf4443890f9a9a345f14646

Stakeholders

Related to #8181 so I'll tag @jimchamp

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #8414 (670f535) into master (337b7b0) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8414   +/-   ##
=======================================
  Coverage   16.62%   16.62%           
=======================================
  Files          84       84           
  Lines        4433     4433           
  Branches      758      758           
=======================================
  Hits          737      737           
  Misses       3212     3212           
  Partials      484      484           

@RayBB RayBB force-pushed the fix/dropper-button-overflow branch from 77c6fc2 to 670f535 Compare October 13, 2023 23:39
@RayBB RayBB requested a review from jimchamp October 13, 2023 23:45
@mekarpeles mekarpeles merged commit e9d3b96 into internetarchive:master Oct 16, 2023
2 checks passed
@mekarpeles
Copy link
Member

Thank you!

@mekarpeles mekarpeles self-assigned this Oct 16, 2023
@cdrini cdrini changed the title fix mybooks-dropper overflow Fix "Want to read" button clipped on mobile Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants