-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Bulk Tagger client-side code #8444
Merged
mekarpeles
merged 8 commits into
internetarchive:master
from
jimchamp:8433/bug/async-bulk-tagger-submissions
Nov 9, 2023
Merged
Refactor Bulk Tagger client-side code #8444
mekarpeles
merged 8 commits into
internetarchive:master
from
jimchamp:8433/bug/async-bulk-tagger-submissions
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
force-pushed
the
8433/bug/async-bulk-tagger-submissions
branch
from
October 19, 2023 23:21
e954e34
to
37dabdf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8444 +/- ##
==========================================
+ Coverage 15.97% 16.03% +0.06%
==========================================
Files 86 86
Lines 4695 4677 -18
Branches 822 816 -6
==========================================
Hits 750 750
+ Misses 3422 3406 -16
+ Partials 523 521 -2 ☔ View full report in Codecov by Sentry. |
jimchamp
changed the title
Prevent Bulk Tagger from redirecting on batch update
[WIP] Refactor Bulk Tagger client-side code
Oct 23, 2023
`/js/ile` is a more appropriate location for the client-side Bulk Tagger code.
jimchamp
force-pushed
the
8433/bug/async-bulk-tagger-submissions
branch
from
November 1, 2023 16:03
ec94ca3
to
01df0f5
Compare
jimchamp
changed the title
[WIP] Refactor Bulk Tagger client-side code
Refactor Bulk Tagger client-side code
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors some of the Bulk Tagger code. Changes:
/js/ile
BulkTagger
class created to encapsulate client-side Bulk Tagger codetype="hidden"
(as opposed to hiding them via CSS)hidden
class to hide the Bulk Tagger?debug=true
from the bulk tagging form'saction
tag_subjects
default in handlerid
in "Tag selections" anchor with anhref
Technical
Testing
Confirm that the bulk tagger is working as expected.
Screenshot
Stakeholders
@mekarpeles