Fix 500 when saving /lists/add with URL parameters + fix global lists editing #8463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no action is specified on the form, it forwards along all the url parameters. This was causing it trouble since it was having collisions between what was specified in the url parameters, vs what was specified in the form data. This commit makes it explicitly consider the form data separately first, so that will always take precedence.
cdrini
changed the title
By default, a <button> acts as a submit button, so will be triggered on enter.
cdrini
force-pushed
the
fix/lists-add-save
branch
from
aa4d10b to
2d5cec4
Compare
cdrini
added
the
On testing.openlibrary.org
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8245 . Closes #8246 .
Fix. Saving from the /lists/add endpoint was erroring when used with url parameters to pre-populate the form. This was because these url parameters would be forwarded along with the POST request when the form was submitted (since the
actionwas unset on the form). The endpoint now checks the request body independently/separately (by default,web.input()combines data from both).Fix. Global lists (eg
/lists/OL1L) were erroring when edited due to the?m=edit→/editrewrite rule not triggering, causing the endpoint to be handled by infogami instead of our custom code. Fixed the rewrite rule.Fix. The
/editrewrite rule was erroring for users when a list had unicode characters in its url (see this users unfortunate list description!). Use thesafe_seeotherthat performs url encoding.Technical
Testing
Tested locally:
Screenshot
Stakeholders
@davidscotson