Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert persona research banner code #8486

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Nov 2, 2023

Closes #8484

Reverts nearly all of #8192. Only the changes to the s3_loan_api function remain.

Technical

Testing

Screenshot

Stakeholders

@mekarpeles
Copy link
Member

LGTM, looks like we have one mypy issue?

openlibrary/catalog/get_ia.py:25: error: Item "None" of "Response | None" has
no attribute "status_code"  [union-attr]
                if error.response.status_code in (403, 404, 416):

Not sure if related to this PR

@cdrini
Copy link
Collaborator

cdrini commented Nov 2, 2023

@mekarpeles Unrelated ; merging this one through since I'm about to deploy and would love to get this fix in!

@cdrini cdrini merged commit d22a7ad into internetarchive:master Nov 2, 2023
2 checks passed
@cdrini
Copy link
Collaborator

cdrini commented Nov 2, 2023

Oh shoot just saw this hadn't been tested yet! I'll take a look on staging before deploying 👍

@cdrini
Copy link
Collaborator

cdrini commented Nov 2, 2023

Tested can log in successfully on staging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging in takes you to an error page
3 participants