Avoid rendering duplicate Vue-related script elements on book pages #8517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8493
The
render_component
function, when called for the first time, appends ascript
element which pulls in Vue. It also renders ascript
element for the specific component the first time that component is rendered on a page.The first time that
render_component
is called on the book page is in theedition/modal_links
template. Prior to these code changes, the rendered modal links were stored in a variable which was rendered twice indatabarWork.html
, resulting in duplicatescript
tags.Since rendering the
edition/modal_links
template takes very little time,render_template
is now called both times the modal links are rendered.Technical
Testing
Screenshot
Stakeholders