Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zero padding to last read date in client-side code #8523

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

KshitijThareja
Copy link
Contributor

Closes #8521

This PR aims to add zero padding to last read date for a book in client-side code.

Testing

Steps to verify:

  1. Mark a book as "Already Read". A prompt for a read date will appear below the dropper. Click the "Other" option to manually enter a date.
  2. Set a read date of 1 January 2023, and submit the form.
  3. You'll see that the day and month will be zero padded wherever expected.

Proof

Screenshot_20231114_122109

WorkingSample.mp4

Stakeholders

@jimchamp

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 16.00%. Comparing base (0c123ab) to head (da1a33b).
Report is 1713 commits behind head on master.

Files with missing lines Patch % Lines
...nlibrary/plugins/openlibrary/js/check-ins/index.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8523   +/-   ##
=======================================
  Coverage   16.00%   16.00%           
=======================================
  Files          86       86           
  Lines        4692     4692           
  Branches      822      822           
=======================================
  Hits          751      751           
  Misses       3416     3416           
  Partials      525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimchamp jimchamp self-assigned this Nov 14, 2023
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KshitijThareja! Will merge this once the suggested changes have been made.

openlibrary/plugins/openlibrary/js/check-ins/index.js Outdated Show resolved Hide resolved
openlibrary/plugins/openlibrary/js/check-ins/index.js Outdated Show resolved Hide resolved
@jimchamp jimchamp added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Nov 15, 2023
@KshitijThareja
Copy link
Contributor Author

KshitijThareja commented Nov 16, 2023

@jimchamp I have made the necessary changes. I should have reviewed my previous submission before making the PR.
I guess this PR can be merged now.

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jimchamp jimchamp merged commit 07d2cfa into internetarchive:master Nov 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last read date not zero-padded by client-side code
3 participants