Add last page shortcut to Author works list #8525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbwhitt
force-pushed
the
feat/author-last-page
branch
from
50a12ee to
e31d652
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8525 +/- ##
=======================================
Coverage 16.00% 16.00%
=======================================
Files 86 86
Lines 4692 4692
Branches 822 822
=======================================
Hits 751 751
Misses 3416 3416
Partials 525 525 ☔ View full report in Codecov by Sentry. |
cdrini
approved these changes
Nov 24, 2023
cdrini
added
the
On testing.openlibrary.org
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8420
Adds a shortcut to the last page of an author's works on the author page.
Technical
Testing
On an author record that has more than 10 pages of works, verify that the last page number is shown separated by an ellipsis.
Additionally, verify that the ellipsis is not present when the last page would normally be shown.
Screenshot
The last page being shown as an option at the beginning of the works.
(For testing, the number of works per page was set to 10 instead of 20)
When towards the back pages, the shortcut is not displayed.
Stakeholders
@cdrini