Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize pngs and gifs #8536

Conversation

davidscotson
Copy link
Collaborator

Closes #8535

feature/refactor (losslessly compressed pngs/gifs, two swapped svgs)

Technical

The SVGs won't show up well in github image diff as it doesn't account for the fact they'll be displayed at the same size.

Testing

visual check of the site looking for broken images.

Screenshot

No visible difference expected.

Stakeholders

Using imageoptim on mac (https://imageoptim.com/command-line.html)
command: open -a imageoptim static/**/*.{png,gif}

Some of these are probably not even used, some improvements are only tiny,
but simplest to do them in bulk.
@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Nov 17, 2023
@cdrini cdrini changed the title 8535/feat/imageoptim ize pngs and gifs Optimize pngs and gifs Nov 20, 2023
@cdrini cdrini self-assigned this Nov 20, 2023
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tested on testing.openlibrary.org , and everything worked nicely.

@cdrini cdrini merged commit 95e2f47 into internetarchive:master Nov 20, 2023
2 checks passed
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run imageoptim over gif and png files in static
3 participants