Improve contrast of subject pills in bulk tagger #8538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
requested changes
Nov 17, 2023
| background-color: @primary-blue; | ||
| } | ||
| } | ||
|
|
||
| .subject-red { |
| person: 'subject-purple', | ||
| place: 'subject-red', | ||
| time: 'subject-yellow' | ||
| subject: 'subject-type-option--subject', |
jimchamp
force-pushed
the
a11y-bulk-tagger-contrast
branch
from
1e73cd7 to
852323c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8538 +/- ##
=======================================
Coverage 16.00% 16.00%
=======================================
Files 86 86
Lines 4692 4691 -1
Branches 822 822
=======================================
Hits 751 751
+ Misses 3416 3415 -1
Partials 525 525 ☔ View full report in Codecov by Sentry. |
cdrini
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves contrast of the subject type pills, found in the "Create new subject" section of the bulk tagger.
Technical
Testing
Screenshot
Before:
After:
Stakeholders
@mheiman