Remove legacy reading log dropper code + "My Books Dropper" feature flag #8539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
force-pushed
the
rm-legacy-dropper-code
branch
from
1663901 to
2b9ed8f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8539 +/- ##
==========================================
+ Coverage 16.00% 16.65% +0.65%
==========================================
Files 86 85 -1
Lines 4692 4406 -286
Branches 822 765 -57
==========================================
- Hits 751 734 -17
+ Misses 3416 3191 -225
+ Partials 525 481 -44 ☔ View full report in Codecov by Sentry. |
jimchamp
added
the
Priority: 1
jimchamp
force-pushed
the
rm-legacy-dropper-code
branch
from
2b9ed8f to
44588a5
Compare
Lists widget is no longer available on subject pages, so there is now no need to render the subject page header.
jimchamp
force-pushed
the
rm-legacy-dropper-code
branch
from
44588a5 to
2304634
Compare
cdrini
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Code lgtm! Searched for a few and found no dangling references. Tested:
Logged out:
- ✅ Appears in search results
- ✅ Clicking in search results sends to login
- Bug: It doesn't forward the url parameters, it just sends you back to
/search
- Bug: It doesn't forward the url parameters, it just sends you back to
- ✅ Appears on book page
- ✅ Clicking on book page sends to login
- Bug: It doesn't forward the url parameters, so returned to wrong edition
- ✅ Does not appear on subject page
- ✅ Add to list appears on Author page
- ✅ Clicking on "Add to list" on authors pages sends you to log in
Logged in:
- ✅ Appears in search results
- ✅ Tap to want to read works
- ✅ Adding to other reading log shelf works
- ✅ Removing from reading log works
- ✅ Appears on book page
- ✅ On books page, my lists containing the edition appear under dropper
- ✅ On books page, click to want to read works
- ✅ Appears on author page
- ✅ Clicking on author page lets you add to list
- Bug: Doesn't close after clicking
- ✅ Your lists are displayed under add to list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes legacy "Want to Read" dropper code, and the related feature flag.
Notable changes:
render_headfunction, removingseed_typeparameter/css/components/dropper.less/css/components/dropper--tablet.less/css/components/generic-dropper.less/css/components/mybooks-dropper.lessreading_logparameter, which held the legacy dropper's rendered HTML string. Droppers now included ifinclude_dropperis truthylegacy_renderingparameterTechnical
Testing
Screenshot
Stakeholders