Make some image/js lazy/late loading #8568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
added
the
Theme: Performance
cdrini
force-pushed
the
fix/small-perf-fixes
branch
from
6f67623 to
4a7a434
Compare
cdrini
added
the
On testing.openlibrary.org
jimchamp
reviewed
Dec 8, 2023
| name: str, | ||
| attrs: dict | None = None, | ||
| json_encode: bool = True, | ||
| asyncDefer=False, |
jimchamp
approved these changes
Dec 8, 2023
cdrini
changed the title
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small performance fixes to lazy load images that are below the fold, and to make JS that doesn't affect the view (ObservationForm javascript)
async defer.Technical
Testing
Screenshot
Logged in. Note everything is 0ms because of service worker interaction.
Stakeholders