Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only load recaptcha JS when needed + DRY recaptcha code #8569

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Only load recaptcha JS when needed + DRY recaptcha code #8569

merged 1 commit into from
Dec 8, 2023

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Nov 27, 2023 •
edited
Loading

  • Previously we were loading the recaptcha JS from google on every /books page and every edit page. We only need it for logged out users, and not at all on the books page, so load it then.
  • Also DRY up recaptcha rendering

Technical

Testing

  • ✅ Invisible recaptcha appears on registration form

Screenshot

Stakeholders

@jimchamp

@cdrini cdrini added the Theme: Performance Issues related to UI or Server performance. [managed] label Nov 27, 2023
@cdrini
Only load recaptcha JS when needed
299ed5e 
- Previously it was loaded on every books page and every edit page. We
only need it for logged out users, so only load it then.
- Also DRY up recaptcha rendering.
@cdrini cdrini force-pushed the refactor/perf-recaptcha-js branch from 73456a8 to 299ed5e Compare November 27, 2023 17:15
@cdrini cdrini added Needs: Testing On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing labels Nov 27, 2023
@cdrini cdrini marked this pull request as ready for review November 27, 2023 17:38
jimchamp
jimchamp approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jimchamp jimchamp merged commit cbd5c97 into internetarchive:master Dec 8, 2023
3 checks passed
@cdrini cdrini deleted the refactor/perf-recaptcha-js branch December 8, 2023 22:59
@jimchamp jimchamp mentioned this pull request Dec 14, 2023
Closed
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimchamp jimchamp jimchamp approved these changes

Assignees

@jimchamp jimchamp

Labels
Theme: Performance Issues related to UI or Server performance. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdrini @jimchamp