Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added: new "Volunteering" card to the "Welcome to Open Library" carousel. #8593

Merged
merged 8 commits into from
Dec 19, 2023
Merged

Added: new "Volunteering" card to the "Welcome to Open Library" carousel. #8593

merged 8 commits into from
Dec 19, 2023

Conversation

xonx4l
Copy link
Contributor

@xonx4l xonx4l commented Dec 6, 2023 •
edited by jimchamp
Loading

Closes #8553

Adds new "Volunteering" card to the "Welcome to Open Library" carousel .

jimchamp
jimchamp requested changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @xonx4l.
A few changes:

  1. Update the card body as per this comment.
  2. Add an attribution.

The image looks kind of small when compared to other cards:
Screenshot from 2023-12-08 16-04-36

Replacing the current image with the following cropped image will solve this:
volunteer

openlibrary/templates/home/welcome.html Outdated Show resolved Hide resolved
openlibrary/templates/home/welcome.html Outdated Show resolved Hide resolved
openlibrary/templates/home/welcome.html Outdated Show resolved Hide resolved
@jimchamp jimchamp added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Dec 9, 2023
xonx4l and others added 5 commits December 17, 2023 19:13
@xonx4l @jimchamp
Update openlibrary/templates/home/welcome.html
e02c009 
Co-authored-by: jimchamp <jameschamp@acm.org>
@xonx4l @jimchamp
Update openlibrary/templates/home/welcome.html
9934e7b 
Co-authored-by: jimchamp <jameschamp@acm.org>
@xonx4l @jimchamp
Update openlibrary/templates/home/welcome.html
7274aeb 
Co-authored-by: jimchamp <jameschamp@acm.org>
@xonx4l
Delete static/images/onboarding/volunteer.png
a8b2443 
deleted small image
@xonx4l
added correct sized image .
6e52f70
@xonx4l
Copy link
Contributor Author

xonx4l commented Dec 17, 2023

@jimchamp thanks for being so helpful and humble .

@jimchamp jimchamp removed the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Dec 19, 2023
jimchamp
jimchamp approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks, @xonx4l!

@jimchamp jimchamp merged commit 6e0db43 into internetarchive:master Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimchamp jimchamp jimchamp approved these changes

Assignees

@jimchamp jimchamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new "Volunteering" card to the "Welcome to Open Library" carousel
2 participants
@xonx4l @jimchamp