Relax yearly already-read page query #8596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes yearly already-read reading log by showing books with checkins that have since been moved to other shelves, e.g. a book that was marked as read but then moved to e.g. "Already Read" or "Currently Reading"
cdrini
requested changes
Dec 7, 2023
There was a problem hiding this comment.
Ah this is causing a bug; see https://testing.openlibrary.org/people/ScarTissue/books/already-read/year/2022
I haven't read the deep learning book. And it doesn't appear to have a check in? I'm not sure why it appears there...
cdrini
added
Needs: Submitter Input
cdrini
reviewed
Dec 7, 2023
| @@ -383,8 +383,7 @@ def get_sorted_reading_log_books( | |||
| FROM bookshelves_books b | |||
| INNER JOIN bookshelves_events e | |||
| ON b.work_id = e.work_id AND b.username = e.username | |||
| WHERE b.bookshelf_id = $bookshelf_id | |||
| AND b.username = $username | |||
| WHERE b.username = $username | |||
| AND e.event_date LIKE $checkin_year || '%' | |||
There was a problem hiding this comment.
Can we maybe filter by a certain check-in type?
openlibrary/openlibrary/core/bookshelves_events.py
Lines 6 to 9 in 68a5584
There was a problem hiding this comment.
They are all FINISH. The other ones are there to support multiple check-ins per work, and are not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes yearly already-read reading log by showing books with checkins that have since been moved to other shelves, e.g. a book that was marked as read but then moved to e.g. "Already Read" or "Currently Reading"
Technical
Testing
Screenshot
Stakeholders