Limit textarea resize within page/container border #8600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8600 +/- ##
=======================================
Coverage 17.61% 17.61%
=======================================
Files 85 85
Lines 4456 4456
Branches 782 782
=======================================
Hits 785 785
Misses 3187 3187
Partials 484 484 ☔ View full report in Codecov by Sentry. |
scottbarnes
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5210
UI fix
Technical
This change adds a
resizefield totextareaelements in the css to restrict the textarea from expanding beyond the page/container borders. For forms that can expand downwards, the value isverticaland for fixed size containers, the value isnone.Testing
Go to any page with a
textareaelement (eg. edit book) and try to resize it; it should only resize vertically for forms that can expand downwards, or not at all for containers that are a fixed size.Pages tested:
Not yet tested:
Screenshot
Before:
After (can only resize vertically inside olform):
Stakeholders