My Books visual fixes #8629
Merged
My Books visual fixes #8629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
added
the
Priority: 0
cdrini
reviewed
Dec 14, 2023
mekarpeles
force-pushed
the
mybooks-breadcrumbs
branch
from
44bb651 to
edf4a0e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8629 +/- ##
=======================================
Coverage 16.68% 16.68%
=======================================
Files 88 88
Lines 4680 4680
Branches 835 835
=======================================
Hits 781 781
Misses 3383 3383
Partials 516 516 ☔ View full report in Codecov by Sentry. |
mekarpeles
force-pushed
the
mybooks-breadcrumbs
branch
from
1272734 to
1c957ee
Compare
mekarpeles
commented
Dec 14, 2023
mekarpeles
force-pushed
the
mybooks-breadcrumbs
branch
from
618af3f to
feab491
Compare
cdrini
approved these changes
Dec 14, 2023
- fixes Loan History class so it't not individually underlined - adds username to to my books page before nav dropper - removed duplicated `notes` from nav dropper - fixed dropper on mobile - removes edit btn from lists
mekarpeles
force-pushed
the
mybooks-breadcrumbs
branch
from
feab491 to
7003a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notesfrom nav dropperResolves outstanding issues from #8597
Nav Dropper Updates
Make it clear what page you're on
EDIT: Mobile
Remove duplicate notes
Fixed sidebar
No underlined link (Loan History took visual precedence over My Loans and the Section was empty for non-owners)
Before:
After:
After (when not owner, hide initial section):
Technical
Testing
Screenshot
Stakeholders