Fixed inconsistent margin gap between search box and search button #8595 #8647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. updated openlibrary/templates/lists/home.html openlibrary/templates/search/inside.html openlibrary/templates/search/lists.html files. Changing .searchInsideForm class to .olform class which solves the issue and maintenaces consistency. 3. updated the references of .searchInsideForm to .olform in tests/integration/test_search.py file.
|
@mekarpeles made a PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8647 +/- ##
==========================================
- Coverage 17.61% 16.68% -0.94%
==========================================
Files 85 88 +3
Lines 4456 4681 +225
Branches 782 835 +53
==========================================
- Hits 785 781 -4
- Misses 3187 3384 +197
- Partials 484 516 +32 ☔ View full report in Codecov by Sentry. |
scottbarnes
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8595
.searchInsideFormclass fromstatic/css/legacy.lessas using.olformclass can will maintain consistency and will allow us to remove code.openlibrary/templates/lists/home.html,openlibrary/templates/search/inside.html,openlibrary/templates/search/lists.html files. Changing.searchInsideFormclass to.olformclass which solves the issue and maintenaces consistency..searchInsideFormto.olformintests/integration/test_search.pyfile.Screenshot( Before)
Screenshot(After)