Emphasize importance of testing before opening a PR in CONTRIBUTING.md #8673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbarnes
approved these changes
Dec 28, 2023
|
Why not add a checkbox along the lines of "Yes, all tests pass (including new ones I've written)" to the pull request template so that it's impossible to miss? Then they don't have to go read a separate document. |
|
@tfmorris I think this is a great way to enforce standards, and will advocate for it during our next ABC call. |
cdrini
changed the title
cdrini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a number of PRs recently that have not been tested. Maybe adding a note about testing in
CONTRIBUTING.mdwill help?Technical
Testing
Screenshot
Stakeholders
@mekarpeles @cdrini @scottbarnes