-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: Highlighted staged changes in BulkTagger #8676
Added: Highlighted staged changes in BulkTagger #8676
Conversation
@jimchamp Can you please review this PR :) |
If this is ready for review, press the "Ready for review" button. |
Yeh I added grey highlighting to highlight the removed changes and yellow for the addition. I can revert the highlight color for removed to yellow :) @jimchamp |
@jimchamp I have made this PR ready for review. If you want me to revert the color of "removed" changes to yellow instead, Ill make a commit 👍 |
@jimchamp Please review it this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8676 +/- ##
==========================================
- Coverage 16.66% 16.60% -0.06%
==========================================
Files 88 88
Lines 4686 4702 +16
Branches 835 839 +4
==========================================
Hits 781 781
- Misses 3389 3404 +15
- Partials 516 517 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @QuantuM410, and apologies for the massive delay. There's not a need for the level of state management that these changes add --- we need only add a single class if an option is staged. If a staged option is highlighted, people need only look for the status icon to know if the tag is being added or removed.
I've added some suggested changes that should simplify things a bit.
@jimchamp I have implemented the required changes |
Closes #8658
This PR addresses the issue outlined in #8658 by enhancing the Bulk Tagger tool to provide visual indications of subjects staged for addition or removal. The proposed solution adds highlighting to the corresponding menu options when a subject is staged.
Technical
The PR integrates the highlighting logic to the staged changes for addition or removal. The highlighting classes are applied based on the updated menu option state. I still have some queries regarding the staged changes as mentioned here
Testing
Open Manage Subjects Menu
Add / Remove subject to view highlighted staged changes
Screenshot
Before Staging changes
After Staging changes
Stakeholders
@jimchamp