Revert blue "Check Options" but keep click behaviour #8685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
force-pushed
the
revert/check-options
branch
from
ae8ca7b to
77a644c
Compare
cdrini
added
the
On testing.openlibrary.org
|
lgtm |
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addendum to #8524 . We had a miscommunication internally about what we wanted the design to look like!
Technical
This basically has the exact same click behaviour as the previous PR (which we discussed during calls w @mekarpeles and @scottbarnes ), but no longer has the blue "check options" button.
Testing
Try it here: https://testing.openlibrary.org/search?q=Teachers%2C+preachers%2C+non-believers&mode=everything
Screenshot
Stakeholders
@mekarpeles @scottbarnes