Made styles of tabs on trending page same as search page. #8703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
requested changes
Jan 11, 2024
There was a problem hiding this comment.
@Ayush1404 your original changes look correct, but I believe you accidentally pushed up another commit? Create unassign_inactive_contributors.py should not be part of the PR.
cdrini
added
the
Needs: Submitter Input
|
Hey, very sorry that I did that, I am a little new to this.I have removed unnecessary commit now, is that okay? |
Ayush1404
force-pushed
the
change_trending_page_tab_style
branch
from
c112577 to
12bc1ae
Compare
Added nav-bar class just like in the searching page to make the menu appear exactly as the searching page.Fixes internetarchive#8702
for more information, see https://pre-commit.ci
Ayush1404
force-pushed
the
change_trending_page_tab_style
branch
from
12bc1ae to
b7f0c24
Compare
|
Sorry i am a little new to this so i did some mistakes but it should be fine now, will be happy to know from you tho |
cdrini
removed
the
Needs: Submitter Input
cdrini
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added nav-bar class just like in the searching page to make the menu appear exactly as the searching page.Fixes #8702
Closes #8702
Changes styles of tabs on the trending page to appear same as same as the search page.
Technical
nav-bar class is used just like in the searching page.
Testing
Visit http://localhost:8080/trending/now on local deployment to see the changes and test them out.
Screenshot
Before:
After:
Stakeholders
@cdrini