Fix share modal iframe url #8738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
commented
Jan 20, 2024
cdrini
commented
Jan 20, 2024
cdrini
added
the
On testing.openlibrary.org
cdrini
force-pushed
the
cdrini-patch-5
branch
from
6d92315 to
cc6b6ef
Compare
Achorn
pushed a commit
to Achorn/openlibrary
that referenced
this pull request
Jan 23, 2024
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously share modals had the wrong url; eg
openlibrary.org, of course since this will be pasted in other people's sites/-/placeholderTechnical
Testing
Tested it creates the right url on testing.
Screenshot
Stakeholders