Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for authenticated requests to the comment digest script #8761

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

jimchamp
Copy link
Collaborator

Adds authorization token to GitHub request headers, iff a token is found in the environment. Also adds API version and Accept headers.

Without authentication, we can only make 60 calls to GitHub's REST API per hour, which sometimes isn't enough to successfully run the new comment digest script. This script can still be executed without an auth token.

Technical

Testing

Screenshot

Stakeholders

jimchamp and others added 2 commits January 25, 2024 11:36
Adds authorization token to GitHub request headers, iff a token is found
in the environment.  Also adds API version and Accept headers.
@mekarpeles mekarpeles merged commit 308312d into internetarchive:master Jan 29, 2024
3 checks passed
@jimchamp jimchamp deleted the bug/workflow-rate-limit branch January 30, 2024 23:57
Achorn pushed a commit to Achorn/openlibrary that referenced this pull request Mar 14, 2024
…nternetarchive#8761)

* Add support for authenticated requests

Adds authorization token to GitHub request headers, iff a token is found
in the environment.  Also adds API version and Accept headers.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants