Fixed Unable to render this page Error when empty spaces passed to search/authors and search/subjects #8805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passing default argument q='' to get_results function.
cdrini
requested changes
Feb 7, 2024
render this page error.
cdrini
reviewed
Feb 7, 2024
strip function to one line.
cdrini
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Tested on testing; all work, thanks @rishabhkr-r111 !
https://testing.openlibrary.org/search/authors
https://testing.openlibrary.org/search/authors?q=john+smith
https://testing.openlibrary.org/search/authors?q=+++
https://testing.openlibrary.org/search/subjects
https://testing.openlibrary.org/search/subjects?q=john+smith
https://testing.openlibrary.org/search/subjects?q=+++
Achorn
pushed a commit
to Achorn/openlibrary
that referenced
this pull request
Mar 14, 2024
…arch/authors and search/subjects (internetarchive#8805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8803
Fixed Unable to render this page Error when empty spaces passed to search/authors and search/subjects.
Technical
It is a simple fix by passing the default argument
q=''toget_resultsfunction insearch/authors.htmlandsearch/subjects.html.Testing
Screenshot
Stakeholders