Handle "Add to staff picks" errors #8849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
force-pushed
the
8473/bug/staff-picks
branch
from
b5d1aec to
460053f
Compare
for more information, see https://pre-commit.ci
rebecca-shoptaw
pushed a commit
to rebecca-shoptaw/openlibrary
that referenced
this pull request
Mar 19, 2024
* Handle "Add to staff picks" errors, avoid catching blind `Exception` --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Achorn
pushed a commit
to Achorn/openlibrary
that referenced
this pull request
Mar 19, 2024
* Handle "Add to staff picks" errors, avoid catching blind `Exception` --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
rebecca-shoptaw
pushed a commit
to rebecca-shoptaw/openlibrary
that referenced
this pull request
Mar 19, 2024
* Handle "Add to staff picks" errors, avoid catching blind `Exception` --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
merwhite11
pushed a commit
to merwhite11/openlibrary
that referenced
this pull request
Mar 27, 2024
* Handle "Add to staff picks" errors, avoid catching blind `Exception` --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8473
Wraps
create_ol_subjects_for_ocaidcall in atry/exceptblock. If any edition is not added to the staff picks, an error message for that edition will be included in the handler'sjsonresponse.Technical
Testing
Screenshot
Stakeholders