Fix thin scrollbar being applied to entire site #8855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This css was leaking and applying to the entire site. We don't want thin scrollbars everywhere.
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8855 +/- ##
=======================================
Coverage 16.02% 16.02%
=======================================
Files 89 89
Lines 4693 4693
Branches 818 818
=======================================
Hits 752 752
Misses 3434 3434
Partials 507 507 ☔ View full report in Codecov by Sentry. |
cdrini
commented
Mar 1, 2024
cdrini
added
the
On testing.openlibrary.org
|
lgtm |
Achorn
pushed a commit
to Achorn/openlibrary
that referenced
this pull request
Mar 14, 2024
* Fix thin scrollbar being applied to entire site This css was leaking and applying to the entire site. We don't want thin scrollbars everywhere. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
merwhite11
pushed a commit
to merwhite11/openlibrary
that referenced
this pull request
Mar 27, 2024
* Fix thin scrollbar being applied to entire site This css was leaking and applying to the entire site. We don't want thin scrollbars everywhere. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This css was leaking and applying to the entire site. We don't want thin scrollbars everywhere.
Technical
Testing
Screenshot
Before:
(note thin scrollbars in body, sidebar)
After:
(normal sized scrollbars)
Stakeholders